-
Notifications
You must be signed in to change notification settings - Fork 8k
soc: nordic: instantiate NRF_PLATFORM_LUMOS kconfig #97474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
soc: nordic: instantiate NRF_PLATFORM_LUMOS kconfig #97474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break MDK, see:
nrfconnect/sdk-zephyr@738549e
What about keeping config NRF_SKIP_CLOCK_CONFIG in the kconfig? and rename CONFIG_SOC_NRF54LX_SKIP_CLOCK_CONFIG to NRF_SKIP_CLOCK_CONFIG because it is going to be used by nrf71x as well. |
e245b89
to
0050c89
Compare
0050c89
to
0b2560f
Compare
@masz-nordic then the MDK should be fixed so that this is possible. |
@tejlmand Not sure what the expected fix here would be, include a zephyr-specific header in MDK? That would create a circular dependency. |
no, make MDK support a config header file which other systems, for example Zephyr, can provide. There is nothing Zephyr specific about |
0b2560f
to
022704d
Compare
I have done the updates as required please have a look again: @nordicjm @masz-nordic @tejlmand @carlescufi |
Instantiate NRF_PLATFORM_LUMOS for all nrf lumos product, Add NRF_SKIP_CLOCK_CONFIG kconfig to be a general kconfig in nordic soc Kconfig, so that it can be used by other lumos product. Signed-off-by: Travis Lam <[email protected]>
022704d
to
4e127d4
Compare
|
SoC series based on the Nordic nRF Lumos platform such as nRF54Lx | ||
series. This allows to easily enable common functionality on | ||
SoCs based on the Haltium platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SoC series based on the Nordic nRF Lumos platform such as nRF54Lx | |
series. This allows to easily enable common functionality on | |
SoCs based on the Haltium platform. | |
SoC series based on the Nordic nRF Lumos platform such as nRF54Lx | |
series. |
Remove Haltium statement, right? Haltium is only the 54Hx series right?
Instantiate NRF_PLATFORM_LUMOS for all nrf lumos product, Add NRF_SKIP_CLOCK_CONFIG kconfig to be a general kconfig in nrfx, so that it can be used by other lumos product.
Currently, there is many nrf54lx series Kconfig are similar and same to be used for future product. I created a new Kconfig called NRF_PLATFORM_LUMOS so that all the Kconfig can be share by products other than NRF54LX, i.e SOC_SERIES_NRF71X. @tejlmand Link to this comment: nrfconnect/sdk-nrf#24475 (comment)